Skip to content

Remove unused envs from dashboard .env.example #5209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

Remove unused envs from dashboard .env.example #5209

merged 1 commit into from
Oct 28, 2024

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 28, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR updates the .env.example file for the dashboard application by removing several configuration variables and their comments, streamlining the environment variable setup.

Detailed summary

  • Removed the comment regarding PAYMENTS_ADMIN_SECRET and the variable itself.
  • Removed the comment about telemetry and the NEXT_TELEMETRY_DISABLED variable.
  • Removed the comment about NEXT_PUBLIC_TRENCH_2_API_ENDPOINT and the variable itself.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 10:37pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 28, 2024 10:37pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 28, 2024 10:37pm
wallet-ui ⬜️ Skipped (Inspect) Oct 28, 2024 10:37pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: be0a4fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 22:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 22:08 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 22:08 Inactive
@MananTank MananTank marked this pull request as ready for review October 28, 2024 22:08
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 28, 2024
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 28, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank mentioned this pull request Oct 28, 2024
Merged
@MananTank MananTank changed the title Remove unused envs from .env.example Remove unused envs from dashboard .env.example Oct 28, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 447 ms (+17.98% 🔺) 1.4 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 854 ms (-17.73% 🔽) 3 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 124 ms (+343.34% 🔺) 221 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 113 ms (+1380.64% 🔺) 123 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 212 ms (+243.31% 🔺) 558 ms

@MananTank MananTank changed the base branch from 10-29-fix_turbo_env_variable_warnings_for_dashboard_build_on_vercel to graphite-base/5209 October 28, 2024 22:15
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024 •
edited
Loading

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/5209 to main October 28, 2024 22:26
@MananTank
Remove unused envs from dashboard .env.example (#5209)
be0a4fc 
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the `.env.example` file for the `dashboard` application by removing deprecated or unnecessary environment variable entries.

### Detailed summary
- Removed the comment regarding `PAYMENTS_ADMIN_SECRET` and its associated empty value.
- Deleted the line to disable telemetry (`NEXT_TELEMETRY_DISABLED`).
- Removed the comment and empty value for `NEXT_PUBLIC_TRENCH_2_API_ENDPOINT`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 10-29-remove_unused_envs_from_.env.example branch from 1da74c1 to be0a4fc Compare October 28, 2024 22:27
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 28, 2024 22:27 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 28, 2024 22:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 28, 2024 22:27 Inactive
@graphite-app graphite-app bot merged commit be0a4fc into main Oct 28, 2024
28 checks passed
@graphite-app graphite-app bot deleted the 10-29-remove_unused_envs_from_.env.example branch October 28, 2024 22:38
@vercel vercel bot temporarily deployed to Production – wallet-ui October 28, 2024 22:38 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 28, 2024 22:38 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 28, 2024 22:38 Inactive
@codecov
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.25%. Comparing base (0b3fe51) to head (be0a4fc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5209   +/-   ##
=======================================
  Coverage   45.25%   45.25%           
=======================================
  Files        1067     1067           
  Lines       55347    55347           
  Branches     3970     3970           
=======================================
  Hits        25049    25049           
  Misses      29606    29606           
  Partials      692      692
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0b3fe51
packages 40.26% <ø> (ø) Carriedforward from 0b3fe51

*This pull request uses carry forward flags. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls